parser: bound the stream parser on an incomplete message - #324
Merged
Conversation
The size limit was only checked once a message parsed in full, so a peer that never finishes one was never stopped. On the partial-parse path ParseNext now sums totalRead and the buffer length and returns ErrMessageTooLarge when that exceeds MaxMessageLength, discarding the buffered bytes: an unfinished message leaves no boundary to resync on. Neither pool is bounded alone. Complete header lines drain into the message and keep the buffer near empty while the message grows; a line that never terminates does the reverse. Only their sum bounds the peer. TCP closes the connection on ErrMessageTooLarge rather than reading on. Refs emiago#323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
The size limit was only checked once a message parsed in full, so a peer that never finishes one was never stopped.