transport: pool a WSS connection under the remote address - #332
Open
Mliviu79 wants to merge 1 commit into
Open
Conversation
TransportWSS.CreateConnection passed (laddr, raddr) to the pool while UDP, TCP, TLS and WS all pass (raddr, laddr). The pool keys on its first argument, so the socket was registered under our own local address -- twice, since the pool also keys c.LocalAddr() -- and under the far end address never. serverRequestConnection looks a connection up by req.Source() for an inbound request, so it missed one that was open and healthy. A WebSocket client is not reachable at its contact address, so that socket is the only path back to it and the request was undeliverable. The test drives CreateConnection against a TLS WebSocket server on loopback and fails on the old order. Refs emiago#331
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331
TransportWSS.CreateConnectionpassed(laddr, raddr)to the pool while UDP, TCP, TLS and WS all pass(raddr, laddr). The pool keys on its first argument, so the socket was registered under our own local address — twice, since the pool also keysc.LocalAddr()— and under the far end address never.serverRequestConnectionlooks a connection up byreq.Source()for an inbound request, so it missed one that was open and healthy. A WebSocket client is not reachable at its contact address, so that socket is the only path back to it and the request was undeliverable.One line of source. The test drives
CreateConnectionagainst a real TLS WebSocket server on loopback with certificate verification left on, and fails on the old order — the existing pool unit tests all pass the arguments in by hand, so none of them can catch a caller composing correct pieces in the wrong order.