sip: add Session-Expires and Min-SE headers - #335
Open
Mliviu79 wants to merge 1 commit into
Open
Conversation
Session-Expires carries a delta-seconds interval plus optional params, and Min-SE a bare delta. Both are exposed as lazy accessors over the generic header passthrough, like Refer-To and Referred-By, so headersParsers stays minimal and messages without session timers are unaffected. Params such as refresher=uac|uas are kept as sent, since electing a refresher and enforcing the Min-SE floor are negotiation policy rather than parsing. Refs emiago#334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #334
Adds
SessionExpiresHeader(uint32 delta-seconds plus optionalHeaderParams) andMinSEHeader(uint32 delta). Both implementHeader—Name,Value,String,StringWrite,headerClone— andSessionExpiresHeaderalso gets a typedClone.Each is reachable through a lazy accessor over the generic header passthrough, in the same shape as
ReferToandReferredBy. TheSession-Expiresaccessor also matches the compact formx.headersParsersis untouched: parsing happens on demand, so a message carrying no session timers does no extra work.Params such as
refresher=uac|uasare stored as sent rather than interpreted, and a malformed value makes the accessor return nil. Electing a refresher and enforcing the Min-SE floor are negotiation policy and stay with the caller — this PR only makes the values readable and writable with a type.Additive API only, no behaviour change to anything existing.