chore: promote the 0.6.0 public API surface - #53
Conversation
|
Thanks, Ruben — I'm on it. I'll review PR #53's PublicAPI baseline changes (the |
There was a problem hiding this comment.
Nothing actionable. Verified against the PR head (7d5a491); note the PR was merged as daa98ff while this review was running, so this lands as a post-merge sign-off.
What was checked
- Matches the documented release step.
CLAUDE.md("Tracked public API surface") says: at release time movePublicAPI.Unshipped.txtentries intoPublicAPI.Shipped.txt, applying*REMOVED*lines as deletions, and leave the unshipped file with just its#nullable enableheader. That is exactly the diff — one deletion in each file, no other edits. - The removal is real, not just bookkeeping.
NetworkException.Bodyis gone from the source (src/Exceptions/PostGuardException.cskeeps only the private_bodyfield from the #41/#43 info-exposure fix), so deleting the shipped line reflects the surface 0.6.0 actually shipped. - Timing is right.
E4A.PostGuard-v0.6.0is tagged and the release commit (174dbf8) is onmain, so the promotion is post-release, not premature. - Baseline is enforced, and it passes.
RS0016/RS0017are both in<WarningsAsErrors>insrc/E4A.PostGuard.csproj, so a shipped line for a member that no longer exists (or an untracked member) breaks the build — the green "Build and test" check is real evidence the new baseline is accurate, not silently drifting. The remainingNetworkException(int statusCode, string! body, string! url) -> voidline still matches the live constructor. - Nothing else was pending.
PublicAPI.Unshipped.txtat the merge base held only the one*REMOVED*entry, so no additions were dropped on the floor. Shipped file stays sorted at 100 lines.
Rule sweep
- Conventional-commit PR title —
.github/workflows/pr-title.ymlexists on this repo and the check passes. - Issue linking —
Part of encryption4all/postguard#247is the deliberate non-closing form, fully qualified for cross-repo, and there is no stray closing keyword elsewhere in the body. The tracking issue correctly stayed open on merge. - Scope and PR body — one commit, two files, no unrelated edits; body is short and states the verification actually run.
- No test change expected here: this is a metadata baseline with no behaviour change, and the analyzer is the test.
One pre-existing thing, out of scope for this PR and not worth its own change: _body is now assigned and never read. That is intentional per the comment above it, and it is left over from #43, not introduced here.
|
Reviewed and approved — pull request review. Nothing actionable, 0 findings. Looks like this merged as |
Release-time step from CLAUDE.md (release-please does not do this): apply the
*REMOVED*entry toPublicAPI.Shipped.txt—NetworkException.Body.getdeleted, matching what 0.6.0 actually shipped — and resetPublicAPI.Unshipped.txtto its#nullable enableheader.Verified:
dotnet buildclean (analyzer accepts the new baseline), tests pass on net10.0.Part of encryption4all/postguard#247 (workstream D housekeeping).