Port to Godot 4#71
Closed
Jummit wants to merge 65 commits into
Closed
Conversation
Jummit
marked this pull request as draft
March 20, 2023 11:29
Jummit
marked this pull request as ready for review
March 20, 2023 11:40
Jummit
force-pushed
the
godot-4
branch
3 times, most recently
from
March 21, 2023 19:17
f9b8cff to
9a68858
Compare
Owner
|
Thanks for the hard work! A WIP (but usable) port to Godot 4 is now available, see #75. |
Author
Hell yeah! Don't worry about the lost work, it was primarily an experiment to see how far Godot 4 has come. I'm excited to use this in a future project when it's ported! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs The Intercept and Crime Scene without issues.
Tests where removed before porting.(Added back now)There are a few tests failing which look bad, but I hope it's nothing too hard to fix.
Debatable changes:
In one commit I removed uses of
self, as the GDScript style guide says not to use it if it isn't necessary.