Fixes for two CI issues#872
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 49 49
Lines 7405 7405
=======================================
Hits 6260 6260
Misses 1145 1145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alifbe
force-pushed
the
fix-fixture-autouse
branch
from
599990e to
618c823
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite to avoid running the datatree session fixture implicitly for every test, since it’s already requested explicitly by the tests that need it. This should reduce unnecessary setup work during test runs.
Changes:
- Removed
autouse=Truefrom thedatatreesession fixture so it only executes for tests that requestdatatree.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alifbe
changed the title
alifbe
force-pushed
the
fix-fixture-autouse
branch
from
618c823 to
cde3e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for two CI issues:
autouse=Truefor the fixture. Remove it the flag fixes the issue since the tests actually explicitly specify the fixture.tsummaryplottests to fail. Update the baseline to fix it.