Add save_model helper for ML-dSGP4 - #30
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a small persistence helper to
mldsgp4:mldsgp4.save_model(path), matching the existingload_model()APIstate_dictequality, and confirms the restored model is in evaluation modeContext
This is a deliberately narrower follow-up to #29.
The feedback on #29 was that the synthetic target used in the proposed training notebook did not represent ML-dSGP4's intended use case of learning against high-precision dynamics. I agree with that concern, so this PR does not reintroduce the training tutorial or synthetic-data example.
The save/load functionality is independent of the choice of training data and directly addresses the model-persistence part of #19. The end-to-end training tutorial can then be handled separately once suitable real ephemeris data is available.
Scope
No propagation or training behaviour is changed. This PR only adds the save helper and its regression test.
Related: #19, #29