feat(ui/inline): allow deleted-line overlay to scroll horizontally#371
Merged
Conversation
Contributor
Author
|
@esmuellert could you help to run CI? i merged main branch to try fixing a failed test for windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
:CodeDiffwith inline layout, if the deleted line is very long, it gets truncated and there's no way to scroll horizontally whenwrapis off.I used
mini.diffbefore and horizontal scrolling worked there, so I stole its implementation to supportvirt_lines_overflowhttps://github.com/nvim-mini/mini.diff/blob/ab11575a6c147ecfba894d676d0c93e855021d34/lua/mini/diff.lua#L945similar PR in gitsigns lewis6991/gitsigns.nvim#1544