fix(navigation): handle hunks past end of buffer for deleted last lines#391
Open
marcomayer wants to merge 4 commits into
Open
fix(navigation): handle hunks past end of buffer for deleted last lines#391marcomayer wants to merge 4 commits into
marcomayer wants to merge 4 commits into
Conversation
marcomayer
force-pushed
the
fix-hunks-past-end-of-buffer
branch
from
618bec5 to
e071a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a hunk deletes the last line(s) of a file, modified.start_line points past the buffer end. Navigation and auto-scroll silently failed because nvim_win_set_cursor rejects out-of-range lines. Now we compare against the unclamped line for ordering but clamp for cursor placement.
I stumbled over this a few times now so I checked if it's easy to fix. And I think it is, unless there are side-effects I didn't think about. Please have a look.