fix(navigation): default cycle_hunks_across_files to false (#412)#415
Merged
Conversation
PR #410 introduced cycle_hunks_across_files but set the default to true, unexpectedly changing ]c/[c to jump across files at the boundary. Restore the legacy behavior (stay within current file) by defaulting to false; users who want cross-file cycling can opt in. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #412. PR #410 introduced the
cycle_hunks_across_filesoption but accidentally set its default totrue, silently changing the behavior of]c/[cso that pressing them on the last hunk of a file would jump to the next file instead of cycling within the current file.This restores the legacy / vim-diff behavior as the default. Users who want cross-file cycling can opt in:
Changes
lua/codediff/config.lua: default flipped tofalseREADME.md: updated documented defaultdoc/codediff.txt: updated documented defaultTest plan
tests/ui/view/cycle_hunks_across_files_spec.luaalready set the option explicitly per case, so both ON and OFF paths remain covered.🤖 Generated with Claude Code