Fix duplicate label set error in certMetaCollector for failed issuances - #53
Merged
Merged
Conversation
Failure records have no serial or issuer, so multiple failures for the
same CN/SAN produce identical label sets in Collect(), causing Prometheus
to abort the scrape. Skip failure records in the collector — they are
already counted by externalcas_certificates_issued_total{status="failure"}.
Signed-off-by: Kapil Agrawal <7047165+netops2devops@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 44.17% 44.28% +0.11%
==========================================
Files 6 6
Lines 489 490 +1
==========================================
+ Hits 216 217 +1
Misses 262 262
Partials 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR issues the fix for a bug in metrics endpoint collector that keeps track of failed certs in metrics.db and thus starting acme-proxy may leads to the following error when querying the metrics endpoint.
note - The acme-proxy server started just fine and was issuing certs.