feat [PKTS-221]: add file input react component - #91
Open
charleshtrenholm wants to merge 1 commit into
Open
Conversation
charleshtrenholm
requested review from
FreddKM,
KatrinaTurner,
echennau,
jkafader-esnet and
johyunjihyunji
June 30, 2026 20:54
Deploying packets-design-system-staging with
|
| Latest commit: |
8621d36
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eae46cad.packets-design-system-staging.pages.dev |
| Branch Preview URL: | https://feat-pkts-221-input-file-rea.packets-design-system-staging.pages.dev |
Deploying packets-design-system with
|
| Latest commit: |
8621d36
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67ae4c3e.packets-design-system.pages.dev |
| Branch Preview URL: | https://feat-pkts-221-input-file-rea.packets-design-system.pages.dev |
charleshtrenholm
force-pushed
the
feat/pkts-221-input-file-react
branch
4 times, most recently
from
July 21, 2026 22:57
5ea45a8 to
64fdaeb
Compare
FreddKM
requested changes
Jul 30, 2026
FreddKM
left a comment
FreddKM
left a comment
Collaborator
There was a problem hiding this comment.
Great work on this. The drag-and-drop file removal logic is a nice touch and the component API feels clean. I left a few comments around file naming consistency, some edge cases with ref forwarding and maxFiles enforcement, and spacing tokens in the CSS. Nothing major, mostly bringing it in line with patterns we use across the rest of the system.
charleshtrenholm
force-pushed
the
feat/pkts-221-input-file-react
branch
from
July 30, 2026 22:20
64fdaeb to
8621d36
Compare
Collaborator
Author
|
Thanks for your review @FreddKM ! Ready for re review whenever 👌 |
FreddKM
approved these changes
Aug 20, 2026
FreddKM
left a comment
FreddKM
left a comment
Collaborator
There was a problem hiding this comment.
Nice work. Approving as-is. A few CSS conventions I missed on the first pass to clean up in a follow up ticket (spacing tokens, prefixed modifier classes, dark mode) but nothing blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds InputFile component with css to react components. Optionally can be styled as either a drag and drop handler or a button that can be clicked. Props extend native
<input type="file">prop types, refer to PktsInputFile.types.ts to see additional props that are custom to component