Match struct elements order in the default config define#799
Open
PetrESP wants to merge 2 commits into
Open
Conversation
PetrESP
force-pushed
the
petr/fix/ft5x06_cpp
branch
from
e4074a7 to
ba8a45a
Compare
PetrESP
force-pushed
the
petr/fix/ft5x06_cpp
branch
from
b2bab04 to
abab6e9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
Fixes #797 by correcting the define order
Note
Low Risk
Initializer reorder only; values unchanged. Workflow change affects CI artifact collection only.
Overview
Reorders designated initializers in the
ESP_LCD_TOUCH_IO_I2C_*_CONFIG()macros for CST816S, FT5x06, GT1151, GT911, and TT21100 so.dev_addrprecedes.scl_speed_hz, matching the member order ofesp_lcd_panel_io_i2c_config_t(fixes #797). Each affected component gets a patch version bump inidf_component.yml.CI upload-artifact paths in benchmark and build-run-applications workflows now collect
/tmp/pytest-embedded/**/*.loginstead of workspace*.log, so pytest-embedded logs are included in failure artifacts.Reviewed by Cursor Bugbot for commit abab6e9. Bugbot is set up for automated code reviews on this repo. Configure here.