Skip to content

fix(batch): clarify Immutable field description in Batch struct #5592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akrem-chabchoub wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix(batch): clarify Immutable field description in Batch struct #5592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b9e8da
docs(batch): clarify Immutable field description in Batch struct
akrem-chabchoub Sep 2, 2026
38aa7e6
fix: lint
akrem-chabchoub Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/p2p/libp2p/stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ func TestStreamVersion(t *testing.T) {

if v == nil {
t.Fatal("expected version to be non-nil")
return
}

expected := semver.Version{Major: tc.wantMajor, Minor: tc.wantMinor}
Expand Down
2 changes: 1 addition & 1 deletion pkg/postage/batch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type Batch struct {
Owner []byte // owner's ethereum address
Depth uint8 // batch depth, i.e., size = 2^{depth}
BucketDepth uint8 // the depth of neighbourhoods t
Immutable bool // if the batch allows adding new capacity (dilution)
Immutable bool // if true, chunks cannot be overwritten when buckets are full
}

// MarshalBinary implements BinaryMarshaller. It will attempt to serialize the
Expand Down
Loading