fix(gsoc): sequential messaging - #5593
Open
nugaon wants to merge 2 commits into
Open
Conversation
gsoc.Handle spawned a goroutine per subscriber handler, so message delivery order to a subscriber was not guaranteed. Call handlers synchronously in registration order instead.
nugaon
force-pushed
the
fix/gsoc-sequential
branch
from
September 2, 2026 15:19
125e62e to
b15df1b
Compare
Contributor
|
@nugaon |
dataC's buffer of 2 was too small for a legitimate burst of GSOC messages delivered concurrently to the same subscriber (e.g. several chunks pushed at once), causing a false-positive slow-consumer disconnect. Bump it to 16 and adjust the slow-consumer test's message count so overflow is still hit deterministically.
Member
Author
|
Thanks for flagging — the ordering fix wasn't the full story. The remaining flakiness in the "parallel" ci-gsoc case (10 messages delivered concurrently to one subscriber) was a false-positive "slow consumer" disconnect: the websocket delivery channel only buffered 2 messages, so a legitimate burst tripped the overflow check meant for genuinely stuck clients. Bumped the buffer to 16 in 0be4122 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addressing #5497 (comment)