Skip to content

refactor: replace full-node flag with explicit node-mode config - #580

Open
martinconic wants to merge 4 commits into
masterfrom
refactor/node-mode-config
Open

refactor: replace full-node flag with explicit node-mode config#580
martinconic wants to merge 4 commits into
masterfrom
refactor/node-mode-config

Conversation

@martinconic

Copy link
Copy Markdown
Contributor

Fixes ethersphere/bee#5172. The previous approach to node mode was implicit and
inconsistent: the mode was inferred from a combination of --full-node
(bool) and whether blockchain-rpc-endpoint was non-empty, which
diverged from the documented definition of modes and allowed silent
misconfigurations.
Bee PR: #5431
This PR introduces a single explicit --node-mode option with three
valid values: full, light, and ultra-light.

@akrem-chabchoub akrem-chabchoub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got in bootnode logs: "starting in light mode"

To reproduce:
./dist/beekeeper create bee-cluster --cluster-name=local --log-verbosity=debug
kubectl logs bootnode-0-0 -n local

Comment thread pkg/orchestration/k8s/cluster.go
Comment thread .github/workflows/go.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate and refactor Bee node modes in node.go

4 participants