Skip to content

Fix/165 168 idempotency and race fixes - #324

Open
whisper011 wants to merge 4 commits into
ethos-protocol:mainfrom
whisper011:fix/165-168-idempotency-and-race-fixes
Open

Fix/165 168 idempotency and race fixes#324
whisper011 wants to merge 4 commits into
ethos-protocol:mainfrom
whisper011:fix/165-168-idempotency-and-race-fixes

Conversation

@whisper011

Copy link
Copy Markdown

Summary

Fixes four correctness bugs around offline sync and auth token refresh on Android and iOS:

Test plan

  • Android: PendingActionSyncWorkerTest, CheckInSyncWorkerTest, VaultViewModelTest,
    ApiClientTest cover idempotency-key resubmission, synced-row dedupe, double-tap
    create-vault guarding, and single-flight token refresh.
  • iOS: CheckInSyncTaskTests covers idempotency-key resubmission after a simulated crash
    and corrupt-queue-file detection.
  • Build environment here couldn't run the Gradle/Xcode toolchains directly (JDK/toolchain
    mismatch, no Swift toolchain available) — please run the test suites in CI before merging.

Closes #165
Closes #166
Closes #167
Closes #168

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@whisper011 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment