Vault management: live TTL countdown, poll/push reconciliation, multi-asset prep, destructive confirmation (#220-#223) - #326
Open
thelux134 wants to merge 1 commit into
Conversation
…-asset prep, destructive confirmation (ethos-protocol#220-ethos-protocol#223) ethos-protocol#221: Add a client-side ticking TTL countdown (TTLCountdown/TtlCountdown) on both platforms, reconciled against the server on every poll and vault_updated push — the server value always wins over the local tick. ethos-protocol#223: Document the poll/push reconciliation rule in shared/api-contract.md (last-applied-wins) and route both platforms' push handling through the same merge point already used for polls, with tests simulating a disagreement. ethos-protocol#222: Add optional assetCode/assetIssuer fields to the Vault model on both platforms (default to native XLM), generalize formattedBalance to use them, document the wire format, and record the remaining XLM-only assumptions in Deposit/Withdraw as a tracked follow-up in PARITY.md. ethos-protocol#220: Add a shared DestructiveConfirmation pattern (typed-text gate + dialog) on both platforms, ahead of any delete/archive endpoint being wired up. Tests assert the guarded action never fires without an exact confirmation match.
|
@thelux134 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#221: Add a client-side ticking TTL countdown (TTLCountdown/TtlCountdown) on both platforms, reconciled against the server on every poll and vault_updated push — the server value always wins over the local tick.
#223: Document the poll/push reconciliation rule in shared/api-contract.md (last-applied-wins) and route both platforms' push handling through the same merge point already used for polls, with tests simulating a disagreement.
#222: Add optional assetCode/assetIssuer fields to the Vault model on both platforms (default to native XLM), generalize formattedBalance to use them, document the wire format, and record the remaining XLM-only assumptions in Deposit/Withdraw as a tracked follow-up in PARITY.md.
#220: Add a shared DestructiveConfirmation pattern (typed-text gate + dialog) on both platforms, ahead of any delete/archive endpoint being wired up. Tests assert the guarded action never fires without an exact confirmation match.
Summary
Changes
Testing
Parity checklist
This PR does not add, change, or remove any user-facing feature on either
platform — no PARITY.md update needed.
— OR —
This PR adds/changes/removes a user-facing feature. I have updated PARITY.md:
Related issues
Closes #221
Closes #223
Closes #222
Closes #220