fix(ci): skip creating a duplicate assetlinks alert issue when one is… - #327
Open
Zalgia-Saga wants to merge 1 commit into
Open
fix(ci): skip creating a duplicate assetlinks alert issue when one is…#327Zalgia-Saga wants to merge 1 commit into
Zalgia-Saga wants to merge 1 commit into
Conversation
|
@Zalgia-Saga Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Android App Links daily verification workflow files a new GitHub issue
every time the scheduled check fails, with no check for an existing open
alert. Since the underlying (server-side) assetlinks.json problem has
persisted across multiple days, this produced four duplicate issues with
identical titles and bodies.
Fix
android-applinks-verify.yml's failure-alert step now searches for anopen issue with the same title before creating one, and skips issue
creation if a duplicate is already open — so the daily check no longer
piles up repeat reports for the same ongoing failure.
Note: the actual assetlinks.json availability issue is server-side
(hosted at ethos-protocol.app) and out of scope for this repo/PR.
Closes #183
Closes #184
Closes #185
Closes #188