Vault management: withdrawal threshold, labels, search/filter, activity history (#216-#219) - #331
Open
Kingsman-99 wants to merge 1 commit into
Open
Conversation
…ty history (ethos-protocol#216-ethos-protocol#219) ethos-protocol#216: Add a configurable large-withdrawal confirmation threshold (WithdrawalThreshold, default 80%). WithdrawView/WithdrawScreen show a warning and require an extra explicit confirmation step before the biometric gate when the entered amount crosses it. Tests cover below/at/ above threshold and that the threshold is a tunable parameter. ethos-protocol#218: Add an optional Vault.label field (both platforms, defaults to nil/ null so it's backward-compatible with existing responses), a POST /vaults/{id}/label contract in api-contract.md, and APIClient.updateVaultLabel/ApiClient.updateVaultLabel. Added a rename action (iOS: RenameVaultView from VaultDetailView; Android: an edit icon + dialog on VaultCard) and a displayName/displayName property used by VaultRowView/VaultCard, falling back to a truncated ID. ethos-protocol#219: Add client-side search (by label/ID) and a status filter chip row (All/Active/Expiring Soon/Expired) to the vault list on both platforms. Implemented as a pure filter (VaultListFiltering.filter / filterVaults) over whatever's already in vaultStore.vaults/state.vaults, so it works across every page already fetched via loadMore()/loadAll() without an extra request; "Load More" is hidden while a filter is active since a filtered view has already searched everything fetched so far. ethos-protocol#217: Add GET /vaults/{id}/history to api-contract.md (reusing the existing cursor/limit pagination pattern), a VaultHistoryEvent model, and a history screen on both platforms (iOS: VaultHistoryView, linked from VaultDetailView; Android: VaultHistoryScreen, reached by tapping a vault card, via a new VaultHistoryViewModel) with its own cursor-based "load more".
|
@Kingsman-99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#216: Add a configurable large-withdrawal confirmation threshold (WithdrawalThreshold, default 80%). WithdrawView/WithdrawScreen show a warning and require an extra explicit confirmation step before the biometric gate when the entered amount crosses it. Tests cover below/at/ above threshold and that the threshold is a tunable parameter.
#218: Add an optional Vault.label field (both platforms, defaults to nil/ null so it's backward-compatible with existing responses), a POST /vaults/{id}/label contract in api-contract.md, and APIClient.updateVaultLabel/ApiClient.updateVaultLabel. Added a rename action (iOS: RenameVaultView from VaultDetailView; Android: an edit icon + dialog on VaultCard) and a displayName/displayName property used by VaultRowView/VaultCard, falling back to a truncated ID.
#219: Add client-side search (by label/ID) and a status filter chip row (All/Active/Expiring Soon/Expired) to the vault list on both platforms. Implemented as a pure filter (VaultListFiltering.filter / filterVaults) over whatever's already in vaultStore.vaults/state.vaults, so it works across every page already fetched via loadMore()/loadAll() without an extra request; "Load More" is hidden while a filter is active since a filtered view has already searched everything fetched so far.
#217: Add GET /vaults/{id}/history to api-contract.md (reusing the existing cursor/limit pagination pattern), a VaultHistoryEvent model, and a history screen on both platforms (iOS: VaultHistoryView, linked from VaultDetailView; Android: VaultHistoryScreen, reached by tapping a vault card, via a new VaultHistoryViewModel) with its own cursor-based "load more".
Summary
Closes #216
Closes #218
Closes #219
Closes #217
Changes
Testing
Parity checklist
This PR does not add, change, or remove any user-facing feature on either
platform — no PARITY.md update needed.
— OR —
This PR adds/changes/removes a user-facing feature. I have updated PARITY.md:
Related issues