fix: #228 #229 #230 #231 OTP accessibility, notification prefs, 2FA backgrounding tests, TOTP clipboard auto-clear - #333
Open
Young850 wants to merge 1 commit into
Conversation
…rotocol#231 OTP accessibility, notification prefs, 2FA backgrounding tests, TOTP clipboard auto-clear ethos-protocol#230 - Add VoiceOver/TalkBack accessibility labels to OTP field (iOS + Android) iOS: .accessibilityLabel/.accessibilityValue/.accessibilityHint on TextField Android: semantics { contentDescription } on OutlinedTextField docs: new OTP accessibility section in manual-qa-checklist.md ethos-protocol#231 - Add NotificationPreferencesView/Screen (iOS + Android) iOS: NotificationPreferences model + NotificationPreferencesView, wired into SettingsView Android: NotificationPreferences model + NotificationPreferencesViewModel + NotificationPreferencesScreen, wired into MainActivity NavHost Both platforms sync preferences server-side (POST /notifications/preferences) ethos-protocol#229 - Add 2FA backgrounding tests (iOS + Android) iOS: TwoFactorBackgroundingTests.swift (OTPRateLimiter + AuthStore scene-phase tests) Android: TwoFactorBackgroundingTest.kt (ViewModel state preservation across process death) Assert OTP digits cleared on resume, cooldown persists, no stale isLoading ethos-protocol#228 - Add TOTP secret clipboard auto-clear + one-time warning (iOS + Android) iOS: TOTPSecretCopyView with 30s auto-clear and UserDefaults-backed one-time alert Android: TotpSecretCopyRow with coroutine-based 30s auto-clear and SharedPrefs warning Tests: TOTPClipboardTests.swift + TotpClipboardTest.kt Update .gitignore: exclude snapshot images, build artifacts, IDE files
|
@Young850 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#230 - Add VoiceOver/TalkBack accessibility labels to OTP field (iOS + Android)
iOS: .accessibilityLabel/.accessibilityValue/.accessibilityHint on TextField
Android: semantics { contentDescription } on OutlinedTextField
docs: new OTP accessibility section in manual-qa-checklist.md
#231 - Add NotificationPreferencesView/Screen (iOS + Android)
iOS: NotificationPreferences model + NotificationPreferencesView, wired into SettingsView
Android: NotificationPreferences model + NotificationPreferencesViewModel +
NotificationPreferencesScreen, wired into MainActivity NavHost
Both platforms sync preferences server-side (POST /notifications/preferences)
#229 - Add 2FA backgrounding tests (iOS + Android)
iOS: TwoFactorBackgroundingTests.swift (OTPRateLimiter + AuthStore scene-phase tests)
Android: TwoFactorBackgroundingTest.kt (ViewModel state preservation across process death)
Assert OTP digits cleared on resume, cooldown persists, no stale isLoading
#228 - Add TOTP secret clipboard auto-clear + one-time warning (iOS + Android)
iOS: TOTPSecretCopyView with 30s auto-clear and UserDefaults-backed one-time alert
Android: TotpSecretCopyRow with coroutine-based 30s auto-clear and SharedPrefs warning
Tests: TOTPClipboardTests.swift + TotpClipboardTest.kt
Update .gitignore: exclude snapshot images, build artifacts, IDE files
Summary
Changes
Testing
Parity checklist
This PR does not add, change, or remove any user-facing feature on either
platform — no PARITY.md update needed.
— OR —
This PR adds/changes/removes a user-facing feature. I have updated PARITY.md:
Related issues
Closes #228
Closes #229
Closes #230
Closes #231