Conversation
…output (#48) * chore: ignore vitest browser snapshots, playwright artifacts and nyc output Adds gitignore entries for test artifacts that are currently generated locally but not tracked: vitest browser __screenshots__, playwright blob results / video (.webm) / trace (.zip), and istanbul .nyc_output. Salvaged from the closed PR #15, which had a valid .gitignore change buried under an obsolete template sync. * chore: sync template after gitignore update - _gitignore: propagate the new test-artifact entries - implement-issue.md: fix lingering reference to create-bhono-app (renamed to create-bhono in #45) The "Verify Template is Synced" CI check fails on any diff under packages/bhono-app/templates/, so the implement-issue.md drift had to be included here.
Pins the @ETUS scope to the public npm registry and configures the auth token explicitly, so install no longer depends on each developer's global ~/.npmrc or the CI runner's default registry. @etus/* is published to registry.npmjs.org with restricted access — the common 404 seen on fresh clones is missing org membership / token, not a publish failure. Also propagates the file into the bhono-app template so scaffolded projects inherit the same explicit config.
#51) Adds lint, client unit tests, template sync check, CLI tests and CLI build to the local pre-push hook, and deletes the GitHub Actions workflows that ran those same checks. Local pre-push now covers everything the deleted workflows did: - test.yml (Code Quality CLI) → CLI test + build steps - template-sync-check.yml → sync:template:check step - changeset-check.yml → covered by changesets release flow Kept workflows: pr-target-check.yml (validates PR base, only knowable server-side) and release.yml (needs NPM_TOKEN). Required status check on master will be updated separately via gh api to point to "PR Target Check".
Adds a header comment pointing to the vitest configs that own the coverage thresholds, and renames the server/client test labels so it is obvious those steps also enforce coverage — not just run tests. No behavior change; gate was already enforced by vitest via the --coverage flag in pnpm test:unit:server and test:unit:client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync of 4 chore PRs already merged in
develop. All are DX / CI infrastructure — none touch app or CLI source code. No version bump, no changesets, no publish triggered.Commits being synced
.npmrcfor@etusscope authenticationImpact on master
.gitignore.nyc_output.npmrc~/.npmrc@etusscope + token config in repo.husky/pre-push.github/workflows/release.yml,pr-target-check.yml) — others moved to local pre-pushCode Quality(ghost, never reported)PR Target Check(real, ~5s)Test plan
src/,packages/*/src/) touched.changeset/*.mdadded — no publish will triggerPR Target Checkshould pass automatically (develop is on the allowed-base list)