fix: transparent bg for commit header and input styles - #589
Conversation
…rent mode ResolveColors eagerly copies Default.Bg into CommitHeader and Input.Item when the theme doesn't set an explicit bg. In transparent/background-image mode, BuildStyleMap skips Default.Bg on the base style, but these resolved backgrounds bypass that — rendering opaque cells over the terminal bg. Clear them when they match Default.Bg before applyStyleDef runs, matching the existing pattern used for the base style and terminal palette. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LefWAS7o3kaDNr4yRNwTaq
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthrough
ChangesTheme background handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Transparent-background mode now allows commit headers and input fields to remain transparent while normal theme backgrounds are preserved when transparency is disabled. No current merge-readiness risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ResolveColorscopiesDefault.BgintoCommitHeaderandInput.Itemwhen the theme doesn't set an explicit bgBuildStyleMapskipsDefault.Bgon the base style, but these resolved backgrounds bypass that — rendering opaque cells over the terminal backgroundDefault.BgbeforeapplyStyleDefruns, matching the existing pattern used for the base style and terminal paletteTest plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01LefWAS7o3kaDNr4yRNwTaq
Summary by CodeRabbit