Skip to content

fix: transparent bg for commit header and input styles - #589

Merged
eugenioenko merged 1 commit into
mainfrom
fix/transparent-bg-resolved-colors
Sep 5, 2026
Merged

fix: transparent bg for commit header and input styles#589
eugenioenko merged 1 commit into
mainfrom
fix/transparent-bg-resolved-colors

Conversation

@eugenioenko

@eugenioenko eugenioenko commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • ResolveColors copies Default.Bg into CommitHeader and Input.Item when the theme doesn't set an explicit bg
  • In transparent/background-image mode, BuildStyleMap skips Default.Bg on the base style, but these resolved backgrounds bypass that — rendering opaque cells over the terminal background
  • Clear resolved backgrounds that match Default.Bg before applyStyleDef runs, matching the existing pattern used for the base style and terminal palette

Test plan

  • Enable transparent background or background image in settings
  • Open a commit detail view — commit header area should be transparent
  • Open search or settings — input fields should have transparent background
  • Disable transparent background — commit header and inputs should show their normal theme background

🤖 Generated with Claude Code

https://claude.ai/code/session_01LefWAS7o3kaDNr4yRNwTaq

Summary by CodeRabbit

  • Bug Fixes
    • Fixed transparent background themes so commit headers and input items no longer inherit the default background color when transparency is enabled.

…rent mode

ResolveColors eagerly copies Default.Bg into CommitHeader and Input.Item
when the theme doesn't set an explicit bg. In transparent/background-image
mode, BuildStyleMap skips Default.Bg on the base style, but these resolved
backgrounds bypass that — rendering opaque cells over the terminal bg.

Clear them when they match Default.Bg before applyStyleDef runs, matching
the existing pattern used for the base style and terminal palette.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LefWAS7o3kaDNr4yRNwTaq
@eugenioenko

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: ce2d543a-85fb-42a9-b0bf-9ca724e570d8

📥 Commits

Reviewing files that changed from the base of the PR and between f6fe484 and b6f2b18.

📒 Files selected for processing (1)
  • internal/app/theme.go

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

BuildStyleMap now clears matching default backgrounds for CommitHeader and Input.Item when transparent backgrounds are enabled.

Changes

Theme background handling

Layer / File(s) Summary
Transparent background fallback
internal/app/theme.go
When WithTransparentBackground is enabled, matching CommitHeader.Bg and Input.Item.Bg values are reset to empty strings.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b6f2b

Transparent-background mode now allows commit headers and input fields to remain transparent while normal theme backgrounds are preserved when transparency is disabled. No current merge-readiness risk remains.

Suggested reviewers: arimxyer

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing transparent background handling for commit headers and input styles.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/transparent-bg-resolved-colors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eugenioenko
eugenioenko merged commit c91dedb into main Sep 5, 2026
12 checks passed
@eugenioenko
eugenioenko deleted the fix/transparent-bg-resolved-colors branch September 5, 2026 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant