feat: add VSCode Dark+ theme - #590
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughAdds a new VS Code Dark Plus theme configuration. The file defines UI colors, editor and syntax colors, terminal ANSI colors, and ASCII border characters. ChangesVS Code Dark Plus theme
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds a bundled VS Code Dark+ theme configuration. No current merge-blocking correctness, security, or runtime risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hi @DBinK, thank you for putting this together! Really appreciate the thoughtful contribution :)
Happy to add this one to the core of ttt. Default Dark was inspired by VS Code's dark theme but, as you pointed out, it's not exactly the same.
If you're up for making more themes, there's a collection of community themes that ship as downloadable JSON rather than in the binary. The files live in config/themes/ and users install them with a one-line curl into ~/.config/ttt/themes/. Adding one is a .json in that folder plus a gallery entry in extra-themes.md; we can help generate the preview image.
Thanks for helping make ttt better for the community!
PS: next release gonna have the option to set background color as transparent so that should also allow for new theme styles. VScode Dark Plus looks fantastic with a dark background out of the box ^^
What
Adds a faithful
vscode-dark-plustheme reproducing the VS Code Dark+ paletteend to end, sourced from the official VS Code theme files:
dark_plus.json/dark_vs.json— editor#1E1E1Ebackground,#D4D4D4foreground,#264F78selection,#094771active list selection,
#37373Dselected tab, iconic#007ACCstatus bar.tokenColors— comment#6A9955, string#CE9178, keyword.control#C586C0, function#DCDCAA, type#4EC9B0,variable
#9CDCFE, constant/builtin#4FC1FF, tag#569CD6.terminalColorRegistry.tsdarkdefaults (red
#CD3131, green#0DBC79, bright red#F14C4C, ...).#FFD700/#DA70D6/#179FFF(Dark+ brackethighlight palette).
Why
default-dark.jsonreuses several Dark+ syntax colors but diverges on theworkbench and terminal surfaces, and colors
keywordblue (#569CD6)where Dark+ uses purple (
#C586C0) for control flow. This theme gives theactual Dark+ look across editor, tabs, sidebar, dialogs, status bar, and
terminal.
Usage
Select in
settings.json:{ "theme": "vscode-dark-plus" }It is discovered automatically via the embedded themes FS
(
go:embed *.json), so it also appears in the theme selector.Verification
TestBundledThemesLoadandTestBundledThemeSemanticDiffForegroundsMeetNormalTextContrastpass withthe new theme included.
--size 80x30 --execrender of a Go file with thetheme selected.
LoadTheme("vscode-dark-plus")resolves Dark+ signature colors (keyword#c586c0, status bar#007acc, terminal red#cd3131).Sources
https://github.com/microsoft/vscode/blob/main/extensions/theme-defaults/themes/dark_plus.json
https://github.com/microsoft/vscode/blob/main/extensions/theme-defaults/themes/dark_vs.json
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts