feat(i18n): localize default journal title and extract from hardcoded values - #147
Merged
evanbones merged 2 commits intoJul 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Context
The default journal title
"My Field Guide"was hardcoded in the Java code. This meant players with non-English clients still saw the English title. This PR moves the default text into the translation system so it respects the player's language.Summary of Changes
"My Field Guide"with a translatable lang keyfieldguide.journal.default.title.null. When no custom title is set, the game now pulls the text from the client's current language file.null, so they correctly fall back to the translated default instead of saving an invisible custom name."My Field Guide"are automatically converted tonullon load, so they pick up the new translated default immediately.Impact