fix: tsc build errs#34
Closed
fcsondheim wants to merge 2 commits into
Closed
Conversation
Coverage Report for @evefrontier/dapp-kit
File CoverageNo changed files found. |
There was a problem hiding this comment.
Pull request overview
This PR addresses TypeScript build errors in the monorepo by adjusting @evefrontier/dapp-kit imports to be type-safe under TS build settings, and bumps package versions/changelogs to reflect the patch release.
Changes:
- Update
ui-componentsandassemblypackage versions (and add corresponding changelog entries). - Fix a
@evefrontier/dapp-kittype import inTurretViewto avoid TS build issues. - Remove unused/invalid type imports in
EveLayout.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/libs/ui-components/package.json | Bumps @eveworld/ui-components version to 0.2.1. |
| packages/libs/ui-components/modules/TurretView.tsx | Switches AssemblyType to a type-only import to resolve TS build errors. |
| packages/libs/ui-components/components/EveLayout.tsx | Removes unused/invalid imports from @evefrontier/dapp-kit. |
| packages/libs/ui-components/CHANGELOG.md | Adds 0.2.1 release notes entry. |
| packages/apps/assembly/package.json | Bumps @eveworld/assembly version to 0.3.1. |
| packages/apps/assembly/CHANGELOG.md | Adds 0.3.1 release notes entry referencing updated dependency. |
|
|
||
| ### Patch Changes | ||
|
|
||
| - fix build err |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix build errs