Skip to content

chore: migrate more wallet-core imports#35

Merged
fcsondheim merged 5 commits into
mainfrom
wallet-core
Jun 11, 2026
Merged

chore: migrate more wallet-core imports#35
fcsondheim merged 5 commits into
mainfrom
wallet-core

Conversation

@fcsondheim

@fcsondheim fcsondheim commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

requires https://github.com/evefrontier/wallet-core/pull/29 to be merged and a new version published.

Bumps dapp version to dapps/v0.3.1
Reverts erroneous version bump of dapp-kit

Copilot AI review requested due to automatic review settings June 10, 2026 20:35
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Coverage Report for @evefrontier/dapp-kit

Status Category Percentage Covered / Total
🔵 Lines 92.59% 475 / 513
🔵 Statements 92.66% 493 / 532
🔵 Functions 88.11% 89 / 101
🔵 Branches 79.54% 280 / 352
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/libs/dapp-kit/utils/constants.ts 100% 100% 100% 100%
packages/libs/dapp-kit/utils/mapping.ts 95.12% 92.85% 100% 95% 26-28
Generated in workflow #71 for commit 62e3a74 by the Vitest Coverage Report Action

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the migration of tenant- and coin-type-related constants/utilities from @evefrontier/dapp-kit into @evefrontier/wallet-core/definitions, updating dapp-kit to import/re-export those definitions instead of maintaining its own copies.

Changes:

  • Switched TENANT_CONFIG usage in utils/mapping.ts to import from @evefrontier/wallet-core/definitions.
  • Removed local tenant constants/config and EVE coin helpers from utils/constants.ts, replacing them with re-exports from wallet-core and deriving TenantConfig/DATAHUB_BY_TENANT from the upstream config.
  • Updated constants.test.ts to drop coverage for the removed KNOWN_EVE_COIN_TYPES symbol.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/libs/dapp-kit/utils/mapping.ts Migrates TENANT_CONFIG import to wallet-core definitions for tenant-specific package ID resolution.
packages/libs/dapp-kit/utils/constants.ts Removes local tenant config/constants and re-exports wallet-core definitions; keeps derived DATAHUB_BY_TENANT.
packages/libs/dapp-kit/utils/__tests__/constants.test.ts Removes tests tied to the deleted KNOWN_EVE_COIN_TYPES export.

Comment thread packages/libs/dapp-kit/utils/__tests__/constants.test.ts
Comment thread packages/libs/dapp-kit/utils/__tests__/constants.test.ts
@fcsondheim fcsondheim merged commit 3661134 into main Jun 11, 2026
3 checks passed
@fcsondheim fcsondheim deleted the wallet-core branch June 11, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants