Remove the index from the test case loop; simplify the cases object - #444
Merged
Merged
Conversation
IsaacG
force-pushed
the
generator.no_idx
branch
from
August 13, 2026 17:22
0603b77 to
327d0e8
Compare
Summarized changes:
```
» g diff | grep '^[+-][^+-]' | sort | uniq -c
1 + "cases": cases,
1 - "cases": list(enumerate(cases)),
77 +{% for case in cases %}
77 -{% for idx, case in cases %}
1 -# generated on 2026-06-30T17:59:19+00:00
1 +# generated on 2026-08-13T17:20:33+00:00
55 - {% if idx == 0 %}# {% endif %}[[ $BATS_RUN_SKIPPED == "true" ]] || skip
21 - {% if idx == 0 %}# {% endif %}[[ $BATS_RUN_SKIPPED == "true" ]] || skip
55 + {% if loop.first %}# {% endif %}[[ $BATS_RUN_SKIPPED == "true" ]] || skip
21 + {% if loop.first %}# {% endif %}[[ $BATS_RUN_SKIPPED == "true" ]] || skip
1 -@test each_file_gets_its_own_forth {
1 +@test "each input file has its own evaluator" {
1 -@test macro_empty_definition {
1 -@test macro_missing_semicolon {
1 +@test "new word definition missing the required semicolon" {
1 +@test "new word with empty definition" {
```
IsaacG
force-pushed
the
generator.no_idx
branch
from
August 14, 2026 16:11
327d0e8 to
ef21954
Compare
Member
Author
|
+cc @glennj |
glennj
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarized changes: