Integrate mentions into the master messenger UI - #27
Open
cassi-volkova wants to merge 1 commit into
Open
Conversation
cassi-volkova
force-pushed
the
cassi/mentions-on-master
branch
from
August 4, 2026 10:27
842ef83 to
72ecbe0
Compare
Member
Author
|
Self-review is complete. The review caught a lifecycle problem in the first port: Activity and Chat could create separate ChatViewModel instances and therefore duplicate catalog loading and WebSocket setup. Both top-level routes now share one instance and one EventsRepository lifecycle. I also removed the screenshot fixture, rechecked owner-scoped mention replacement, stream/topic unread projection, message-to-conversation navigation, and the final master diff. I found no remaining issues after the unit, lint, clean-build, and physical-device passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@badgesVerification
./gradlew test./gradlew lintExordosDebug./gradlew clean assembleExordosDebug@, topic@, and opening the matching conversation from a mentionThe device screenshots contain live Workspace content, so they are being shared only in the originating Workspace topic.