[eas-cli] Print actionable error when app config can't be read because dependencies aren't installed - #4080
Open
expo-tuft[bot] wants to merge 11 commits into
Open
[eas-cli] Print actionable error when app config can't be read because dependencies aren't installed#4080expo-tuft[bot] wants to merge 11 commits into
expo-tuft[bot] wants to merge 11 commits into
Conversation
…stalled Co-authored-by: ide <379606+ide@users.noreply.github.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Co-authored-by: ide <379606+ide@users.noreply.github.com>
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
…back Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 24, 2026
ide
reviewed
Jul 24, 2026
…ing getConfig Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 24, 2026
Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4080 +/- ##
==========================================
+ Coverage 61.59% 61.64% +0.06%
==========================================
Files 981 981
Lines 43960 44003 +43
Branches 9225 9240 +15
==========================================
+ Hits 27072 27123 +51
+ Misses 15441 15434 -7
+ Partials 1447 1446 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…Expo CLI Co-authored-by: ide <379606+ide@users.noreply.github.com>
Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 24, 2026
Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 24, 2026
Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 25, 2026
Co-authored-by: ide <379606+ide@users.noreply.github.com>
ide
reviewed
Jul 25, 2026
Co-authored-by: ide <379606+ide@users.noreply.github.com>
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running EAS CLI in a project whose dependencies aren't installed (e.g.
npx eas-cli credentialsright after cloning) failed with a confusing error when the app config lists config plugins:The error hints at the problem but doesn't say what to do. EAS CLI needs the project's dependencies to read the app config — it runs
expo configwith the project's own copy of Expo CLI so the config is resolved consistently — so this case should be handled gracefully with a useful error message.How
In the branch where the project's Expo CLI isn't resolvable, check upfront whether
expois declared inpackage.jsondependencies but can't be resolved — the signal that dependencies aren't installed. In that case, fail immediately with a direct, actionable message that includes the install command detected from the project's lockfile (npm/yarn/pnpm/bun viaresolvePackageManager):Config resolution itself is unchanged: projects with Expo CLI available still run
expo config, and projects that don't declareexpoare still read with the copy of@expo/configbundled with EAS CLI.Test Plan
expois declared but not installed, and the bundled@expo/configfallback whenexpoisn't declared.yarn test src/project/__tests__/expoConfig.test.tspackage.jsondeclaringexpo/expo-router, nonode_modules,app.jsonwith"plugins": ["expo-router"]):eas credentialsfailed with only theFailed to resolve plugin for module "expo-router"error.yarn.lockpresent it suggestsyarn install, otherwisenpm install.expoin dependencies behaves as before.