Skip to content

[eas-cli] improve wording for additional usage - #4094

Open
kadikraman wants to merge 5 commits into
mainfrom
kadikraman/extra-use
Open

[eas-cli] improve wording for additional usage#4094
kadikraman wants to merge 5 commits into
mainfrom
kadikraman/extra-use

Conversation

@kadikraman

@kadikraman kadikraman commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Why

Currently we print our information about extra use as "overages" which is misleading.

https://exponent-internal.slack.com/archives/C02123T524U/p1784989673512749

How

Replace "overages" -> "extra use" in the usage command and in the pre-build usage printout.

eas build (warning shown before starting a build, when over included credits)

Before

You've used 3 builds beyond your included credits this billing period ($4.50 in overages so far).
Additional builds continue at pay-as-you-go rates. See usage in billing.

After

You've used 3 builds beyond your included credits this billing period ($4.50 in additional usage so far).
Additional builds continue at pay-as-you-go rates. See usage in billing.

eas account:usage

Before

EAS Build
  Builds (plan): 50/50
  ████████████████████ 100%
  Builds (overage): 5 builds ($15.00)

EAS Update
  Unique Updaters (plan): 3,500/3,000 users
  ████████████████████ 100%
  Unique Updaters (overage): 500 users ($2.50)

Billing
  Base subscription: $19.00
  Current overages: $17.50
    Build overages: $15.00
      iOS large: 2 builds ($10.00)
    Update overages: $2.50
  Estimated bill: $36.50

After

EAS Build
  Builds (plan): 50/50
  ████████████████████ 100%
  Builds (additional usage): 5 builds ($15.00)

EAS Update
  Unique Updaters (plan): 3,500/3,000 users
  ████████████████████ 100%
  Unique Updaters (additional usage): 500 users ($2.50)

Billing
  Base subscription: $19.00
  Additional usage: $17.50
    Builds: $15.00
      iOS large: 2 builds ($10.00)
    Updates: $2.50
  Estimated bill: $36.50

Test Plan

Updated / added tests.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@kadikraman
kadikraman requested a review from sarahlane8 July 27, 2026 14:54
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (83b86b8) to head (6c15548).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4094      +/-   ##
==========================================
+ Coverage   61.93%   62.11%   +0.18%     
==========================================
  Files         990      990              
  Lines       44447    44447              
  Branches     9340     9340              
==========================================
+ Hits        27524    27602      +78     
+ Misses      15471    15403      -68     
+ Partials     1452     1442      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brentvatne brentvatne added the ai-review Commits pushed to PRs with this label be automatically reviewed. label Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

🤖 AI code review

Decision: Approve with comments

One lint-related warning remains in the updated usage test: the eslint disable comment does not cover the control-character regex it is meant to suppress.

🟡 Warning (1)

  • Disable comment does not cover the control-character regexpackages/eas-cli/src/commands/account/__tests__/usage.test.ts:245 (quality) · id:066a8f3dff49
    The eslint-disable-next-line no-control-regex comment only applies to the preceding const output = ... line, while the regex literal that triggers no-control-regex is on this later .replace(...) line. This leaves the lint violation unsuppressed and can make yarn lint fail.
    Suggestion: Move the disable comment directly above the .replace(...) line or use a block disable around the chained expression.

This review is advisory — it never blocks a merge and never auto-approves.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Commits pushed to PRs with this label be automatically reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants