Skip to content

[eas-cli] Make simulator the index command - #4112

Open
szdziedzic wants to merge 3 commits into
mainfrom
szdziedzic-codex/simulator-index-command
Open

[eas-cli] Make simulator the index command#4112
szdziedzic wants to merge 3 commits into
mainfrom
szdziedzic-codex/simulator-index-command

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move the simulator start implementation from simulator/start.ts to simulator/index.ts
  • make eas simulator the canonical command and retain eas simulator:start as an alias
  • preserve the hidden status of the experimental simulator command family

Why

simulator:start was the canonical oclif command and simulator was only an alias. Making simulator the index command establishes the shorter form as canonical while preserving compatibility with simulator:start.

Validation

  • corepack yarn build
  • corepack yarn test src/commands/simulator --runInBand (45 tests)
  • oxfmt --check on modified files
  • oxlint --type-aware --import-plugin on modified files
  • packages/eas-cli/bin/run simulator --help
  • packages/eas-cli/bin/run simulator:start --help
  • corepack yarn lint-changelog

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (2e00719) to head (2bdd631).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4112   +/-   ##
=======================================
  Coverage   62.20%   62.20%           
=======================================
  Files         994      994           
  Lines       44716    44716           
  Branches     9409     9409           
=======================================
  Hits        27812    27812           
  Misses      15457    15457           
  Partials     1447     1447           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@szdziedzic
szdziedzic marked this pull request as ready for review July 29, 2026 16:39
@szdziedzic
szdziedzic requested a review from sjchmiela July 29, 2026 16:39
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant