[build-tools] Stop agent-device artifact polling before daemon shutdown - #4115
Closed
szdziedzic wants to merge 2 commits into
Closed
[build-tools] Stop agent-device artifact polling before daemon shutdown#4115szdziedzic wants to merge 2 commits into
szdziedzic wants to merge 2 commits into
Conversation
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4115 +/- ##
==========================================
+ Coverage 62.25% 62.25% +0.01%
==========================================
Files 994 994
Lines 44820 44843 +23
Branches 9425 9431 +6
==========================================
+ Hits 27897 27913 +16
- Misses 15474 15481 +7
Partials 1449 1449 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #4114.
The agent-device artifact poller was launched as a detached, unconditional loop. Once the remote session ended, teardown stopped the daemon but the poller kept requesting its artifact endpoint forever, producing repeated failures and periodic Sentry reports.
How
finallyso an earlier preview or tunnel cleanup failure cannot leave the poller and daemon running.Test Plan
corepack yarn test src/steps/utils/__tests__/agentDeviceArtifacts.test.ts src/steps/functions/__tests__/startAgentDeviceRemoteSession.test.ts --runInBand(11 tests)corepack yarn typecheckinpackages/build-tools