Teach ghstack pull to update whole local stacks#355
Open
ezyang wants to merge 1 commit into
Open
Conversation
[ghstack-poisoned]
Owner
Author
|
Stack from ghstack (oldest at bottom): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ghstack pull is run from the top of a local stack, pull each PR bottom-up instead of only updating the HEAD PR. This keeps parent PR source ids current before replaying later local commits, so a subsequent ghstack submit --stack does not fail on a stale lower commit.
Also make pull robust to rewritten remote head histories by falling back to a synthetic merge base from the recorded ghstack-source-id tree when the old head commit is not reachable.
Add regression tests for rewritten head history, stale parent repair after a top-only pull, and repeated pulls preserving the final tree.