Add S3 multipart threshold configuration for object lock support - #10
Merged
Conversation
Buckets with object lock enabled (e.g. Selectel compliance lock) answer CompleteMultipartUpload with AccessDenied, so `aws s3 cp` fails for every dump above the default 8MB multipart threshold. Raise the threshold to 5GB — the maximum size of a single S3 upload — so dumps go up in one request, and make it configurable through S3_MULTIPART_THRESHOLD for anyone who wants the multipart behaviour back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KQwdZqNR3dWZi17tbSRq3j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds support for S3 buckets with object lock (WORM/compliance lock) enabled by introducing a configurable multipart upload threshold. Buckets with object lock can reject
CompleteMultipartUploadrequests, so this feature allows uploads to be performed in a single request when the dump is small enough.Key Changes
S3_MULTIPART_THRESHOLDenvironment variable (default:5GB) to control when multipart uploads are usedaws configure set default.s3.multipart_thresholdS3_REGIONconfiguration5GB(the maximum size of a single S3 upload) to avoid multipart uploads for most dumpsImplementation Details
backup.shbefore any S3 operationsS3_MULTIPART_THRESHOLDto a lower value (e.g.,8MB) to enable multipart uploads for smaller filesS3_REGIONmust match the bucket's region to avoid unnecessaryAuthorizationHeaderMalformederrors during retrieshttps://claude.ai/code/session_01KQwdZqNR3dWZi17tbSRq3j