Skip to content

fix(ci): accept trusted legacy PR metadata - #5740

Merged
cixzhang merged 1 commit into
facebook:mainfrom
cixzhang:fix-legacy-preview-metadata
Aug 31, 2026
Merged

fix(ci): accept trusted legacy PR metadata#5740
cixzhang merged 1 commit into
facebook:mainfrom
cixzhang:fix-legacy-preview-metadata

Conversation

@cixzhang

Copy link
Copy Markdown
Contributor

Summary

  • validate PR analysis metadata through the shared trusted validator instead of requiring fields older open PRs never emitted
  • retain exact PR number, source run ID, and head-prefix checks for legacy artifacts
  • continue enforcing every exact identity field whenever it is present

Why

A live recovery for #5671 used a fresh trusted CI run, but its older branch emits the pre-proof pr-meta.json shape. Current default-branch publication rejected it before reaching the now-fixed tall screenshot.

Test plan

  • pnpm exec vitest run .github/scripts/lib/pr-preview.test.mjs .github/scripts/visual-gate/workflow-concurrency.test.mjs
  • pnpm exec actionlint -ignore 'label "2-core-ubuntu-arm" is unknown' .github/workflows/pr-comment.yml
  • pnpm check:repo
  • git diff --check

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 3:40am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 31, 2026
github-actions Bot added a commit that referenced this pull request Aug 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Preview availability: Storybook and Sandbox were not published for this CI run.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.


Generated by PR Enrichment workflow | View full report

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic verdict: approve once undrafted.

🟢 No review blockers found — this preserves the default-branch trust boundary while letting old, already-trusted pr-meta.json artifacts render again. Triage: CI bug fix · non-breaking · trust-sensitive workflow path → full path · checks: exact workflow-run identity, legacy metadata compatibility, exact-field enforcement, mismatch rejection, deployment-proof preservation, actionlint, focused tests, and CI.

I checked exact head bd6aced7fa963d67957c16417c105c4dfaf6dbf3: the #5671 artifact has the old shape (prNumber, shortHash, storybookUrl, sandboxUrl, runId, runUrl) and is accepted only for the exact trusted PR/run/head-prefix identity. Wrong PR, wrong run, wrong head prefix, missing short hash, and mismatched exact identity fields all still reject; deployment proof validation is unchanged. CI is green. Full evidence: https://github.com/cixzhang/astryx/wiki/Review-5740

Because this PR is still draft and self-authored, GitHub may not accept a formal approval event; this is the semantic approval for the reviewed head.

[Reviewed by Agentcloud]

@cixzhang
cixzhang marked this pull request as ready for review August 31, 2026 04:04
@cixzhang
cixzhang merged commit e13faef into facebook:main Aug 31, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant