docs(Popover): compact component contract - #5869
Closed
cixzhang wants to merge 1 commit into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
cixzhang
force-pushed
the
agentcloud/popover-contract-compaction
branch
from
September 2, 2026 00:59
d736165 to
cea8cde
Compare
cixzhang
force-pushed
the
agentcloud/popover-contract-compaction
branch
from
September 2, 2026 01:50
cea8cde to
9583607
Compare
github-actions
Bot
deleted the
agentcloud/popover-contract-compaction
branch
September 2, 2026 06:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: benchmark blocked
This draft is not ready for approval. A two-attempt reviewer benchmark at frozen authority
701fd39bfound that the compact Popover contract reduced contract context by 44.6%, but did not preserve review quality on #5675:The compact record remains semantically faithful as documentation, but it fails the stricter question that now matters: whether it helps reviewers identify the right decisions and blockers. Keep this PR draft until the compact structure restores that signal and passes the repeatable benchmark.
Why
The current Popover contract repeats evidence and shared-system rules, making its durable promises harder to scan and audit. This documentation-only change keeps the settled contract intact while making it substantially smaller.
What
Risk
Documentation-only compaction. No runtime, public API, consumer-facing documentation, target, behavior, migration, or release-status change.
The reviewer benchmark identifies a separate risk: semantic parity does not guarantee equal review-decision quality.
Testing
pnpm exec prettier --check packages/core/src/Popover/Popover.spec.mdpnpm check:knowledge --base origin/mainpnpm exec vitest run packages/core/src/Popover/Popover.test.tsx packages/core/src/hooks/useFocusTrap.test.tsx(60 tests)pnpm check:repoNo Changeset: this compacts an existing contract without changing a published package or consumer-facing promise.