Skip to content

[Nexthop][wedge800bnhp] Avoid creating TH5 port serdes with zeroed TX FIR / empty Preemphasis - #1592

Closed
andrew-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:fix-agent_hw-VerifyPortRateTraffic-test
Closed

andrew-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:fix-agent_hw-VerifyPortRateTraffic-test

Conversation

@andrew-nexthop

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

On Tomahawk5, recreating a port serdes under zeroPreemphasis=true (set by LinkStateToggler in HW loopback tests) crashes during a VCO change that forces a port recreate:

  • For optical profiles, avoid creating the serdes object with zeroed TxFirMain values. Create it without the TX FIR taps, then program the zeroed taps in a follow-up update accepted by the SDK.
  • Preserve the existing copper-profile path and avoid programming an empty Preemphasis attribute when no TX lanes are present.

Test Plan

wedge800bnhp:

Running all tests took 0:00:46.291503 between 2026-06-15 22:35:01.767058 and 2026-06-15 22:35:48.058561
[ PASSED ] cold_boot.AgentPortBandwidthTest/AgentPortBandwidthParamTest.VerifyPortRateTraffic/1 (10631 ms)
[ PASSED ] warm_boot.AgentPortBandwidthTest/AgentPortBandwidthParamTest.VerifyPortRateTraffic/1 (9513 ms)
[ PASSED ] cold_boot.AgentPortBandwidthTest/AgentPortBandwidthParamTest.VerifyPortRateTraffic/3 (10583 ms)
[ PASSED ] warm_boot.AgentPortBandwidthTest/AgentPortBandwidthParamTest.VerifyPortRateTraffic/3 (9488 ms)
Summary:
   PASSED : 4
   FAILED : 0
   SKIPPED : 0
   TIMEOUT : 0

Signed-off-by: raghavv-nexthop <raghavv@nexthop.ai>
@andrew-nexthop
andrew-nexthop requested a review from a team as a code owner September 3, 2026 19:43
@meta-cla meta-cla Bot added the CLA Signed label Sep 3, 2026
@meta-codesync

meta-codesync Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@tanmayaudupa has imported this pull request. If you are a Meta employee, you can view this in D121230677.

@meta-codesync meta-codesync Bot closed this in 01d4611 Sep 23, 2026
@meta-codesync

meta-codesync Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

@tanmayaudupa merged this pull request in 01d4611.

@meta-codesync meta-codesync Bot added the Merged label Sep 23, 2026
@andrew-nexthop
andrew-nexthop deleted the fix-agent_hw-VerifyPortRateTraffic-test branch September 23, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants