[Meta][feature]Set up PR title "project" labeling workflow (#1593) - #1593
Open
Scott8440 wants to merge 1 commit into
Open
[Meta][feature]Set up PR title "project" labeling workflow (#1593)#1593Scott8440 wants to merge 1 commit into
Scott8440 wants to merge 1 commit into
Conversation
Contributor
|
@Scott8440 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116517070. |
Scott8440
changed the title
Summary: After experimentation and discussion, we've decided to move most of the routing logic internally to reuse the existing NPI tracking system, which gives us a lot of the things we need for this. What will need to be handled in github is this: * "Project" labeling system for vendor to indicate who should be responsible for reviewing <- This diff * Contributor-facing signals on PRs for unattended/unlabeled PRs * Assignee field mainly used for vendor visibility Internally we will handle: * Ownership routing (based on information from the PR + internal configs and tooling) * Reminders * Handoffs * Tracking This first diff introduces a Project label, similar to the vendor label which is parsed from the PR title and added as a proper label to the PR. The list of valid projects will be a simple `.json` file visible to vendors to enable proper titles. * Initially we will not add "missing" labels or bot comments for incorrect titles, but we will later once more infrastructure is set up * The list of projects will need to be updated manually (for now). I am working with the Platform team to add an item to the NPI tracker checklist which will ensure that a new NPI gets added to this list. * Most labels are for specific NPI platforms, but other more generic labels exist such as "mosaic", "bug fix", and "feature". This can be revisited. Example PR titles: ``` [Accton][minipack3n] Add transceiver support [Arista][feature] Support reload cause logging in platform_manager ``` Differential Revision: D116517070
meta-codesync
Bot
changed the title
Scott8440
force-pushed
the
export-D116517070
branch
from
September 9, 2026 18:28
d051e7b to
7b74e37
Compare
Scott8440
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
After experimentation and discussion, we've decided to move most of the routing logic internally to reuse the existing NPI tracking system, which gives us a lot of the things we need for this. What will need to be handled in github is this:
Internally we will handle:
This first diff introduces a Project label, similar to the vendor label which is parsed from the PR title and added as a proper label to the PR. The list of valid projects will be a simple
.jsonfile visible to vendors to enable proper titles.Example PR titles:
Differential Revision: D116517070