[Accton][wedge800cact] Remove unused G202X TEMP_5~8 SMB_CPLD sensors - #1604
Open
brandonchuang wants to merge 1 commit into
Open
[Accton][wedge800cact] Remove unused G202X TEMP_5~8 SMB_CPLD sensors#1604brandonchuang wants to merge 1 commit into
brandonchuang wants to merge 1 commit into
Conversation
Summary:
Remove the four SMB CPLD temperature sensors `SMB_U72_G202X_TEMP_5` through
`SMB_U72_G202X_TEMP_8` from the wedge800cact `sensor_service.json`.
Motivation:
The SMB reads the MAC-surrounding temperatures from the SMB CPLD (tmp432),
exposed as `temp<N>_input` under `/run/devmap/sensors/SMB_CPLD/`.
- The previous MAC, G200X, exposed 8 tmp432 temperature channels
(`temp1_input`~`temp8_input`), so the config carried
`SMB_U72_G202X_TEMP_1`~`SMB_U72_G202X_TEMP_8`.
- The new MAC, G202X, is introduced starting from DVT and only requires
4 of these channels (`temp1_input`~`temp4_input`).
On G202X, `temp5_input`~`temp8_input` are not connected to any real device and
simply read back **0** (this does not produce a read error). These constant
0 readings are meaningless and misleading in sensor data, so channels 5~8 are
removed to keep the config aligned with the G202X hardware.
Changes:
- `wedge800cact` Netlake-2 `sensor_service.json`:
- Remove the sensor definitions for `SMB_U72_G202X_TEMP_5`,
`SMB_U72_G202X_TEMP_6`, `SMB_U72_G202X_TEMP_7`, and `SMB_U72_G202X_TEMP_8`
(mapped to `SMB_CPLD/temp5_input`~`temp8_input`).
- Remove the same four names from the ASIC `temperatureSensorNames` list so
only `SMB_U72_G202X_TEMP_1`~`SMB_U72_G202X_TEMP_4` remain.
Test plan:
- Validated `sensor_service.json` is still valid JSON after the removal.
- Confirmed only `SMB_U72_G202X_TEMP_1`~`_4` remain, both in the sensor
definitions and in the ASIC `temperatureSensorNames` list.
- On hardware, sensor_service reads the four remaining SMB CPLD temperatures
normally. Before the change, `temp5_input`~`temp8_input` read a constant 0
(no read error) and only added noise to the sensor data; they are gone after
the removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.........................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Prevent sai_impl in fboss manifest.......................................Passed
Summary:
Remove the four SMB CPLD temperature sensors
SMB_U72_G202X_TEMP_5throughSMB_U72_G202X_TEMP_8from the wedge800cactsensor_service.json.Motivation:
The SMB reads the MAC-surrounding temperatures from the SMB CPLD (tmp432), exposed as
temp<N>_inputunder/run/devmap/sensors/SMB_CPLD/.temp1_inputtotemp8_input),so the config carried
SMB_U72_G202X_TEMP_1toSMB_U72_G202X_TEMP_8.temp1_inputtotemp4_input).On G202X,
temp5_input~temp8_inputare not connected to any real device and simply read back 0 (this does not produce a read error). These constant 0 readings are meaningless and misleading in sensor data, so channels 5-8 are removed to keep the config aligned with the G202X hardware.Changes:
wedge800cactNetlake-2sensor_service.json:SMB_U72_G202X_TEMP_5,SMB_U72_G202X_TEMP_6,SMB_U72_G202X_TEMP_7, andSMB_U72_G202X_TEMP_8(mapped toSMB_CPLD/temp5_input-temp8_input).temperatureSensorNameslist so onlySMB_U72_G202X_TEMP_1-SMB_U72_G202X_TEMP_4remain.Test plan:
sensor_service.jsonis still valid JSON after the removal.SMB_U72_G202X_TEMP_1~_4remain, both in the sensor definitions and in the ASICtemperatureSensorNameslist.Before the change,
temp5_input~temp8_inputread a constant 0 (no read error) and only added noise to the sensor data; they are gone after the removal.w800c_g202x_sensor_service_log.txt