[Nexthop] Skip setting CREATE_ONLY next hop group attributes - #1605
Open
daria-nexthop wants to merge 1 commit into
Open
[Nexthop] Skip setting CREATE_ONLY next hop group attributes#1605daria-nexthop wants to merge 1 commit into
daria-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: daria-nexthop <daria@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
The HW agent SIGABRTs on warm boot in
AgentFlowletSprayTest.VerifyEcmpRandomSprayandAgentLoadBalancerTestV6EcmpSpray.EcmpLoadBalanceFullHashCpuTrafficon Tomahawk6 platforms.SAI_NEXT_HOP_GROUP_ATTR_HIERARCHICAL_NEXTHOPisCREATE_ONLYin the SAI spec, and Broadcom 14.2 SAI doesn't implement a getter. On warm bootSaiStore::reload()falls back to the attribute'sStdNullOptDefault, andSaiObject::checkAndSetAttributeseesnullopt != falseand issues a set on a create only attribute, which returnsNOT_SUPPORTEDand hw agent aborts.This change adds an
IsCreateOnlyAttributetrait, specialised forHierarchicalNextHop.checkAndSetAttribute()no longer writes create-only attributes to hardware; instead, the store adopts the desired value in its cache, preserving the value programmed during object creation.HashAlgorithmis included on spec grounds: it is alsoCREATE_ONLY, but it does not trigger this issue because Broadcom SAI implements its getter.Test Plan
The tests now pass: