Skip to content

[Cisco] Enable unresolved-route class ID before Copp warmboot replay. - #1620

Closed
ram316583 wants to merge 1 commit into
facebook:mainfrom
ram316583:sep09.2026.saisinga/classid_unresolved_routes_warmboot
Closed

ram316583 wants to merge 1 commit into
facebook:mainfrom
ram316583:sep09.2026.saisinga/classid_unresolved_routes_warmboot

Conversation

@ram316583

@ram316583 ram316583 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

AgentCoppTest::UnresolvedRouteNextHopToLowPriQueue was setting FLAGS_classid_for_unresolved_routes inside the per-test setup() lambda.

On warmboot, setup() is skipped. SAI route replay then programs unresolved CPU routes with Metadata 0, so traffic hits IP2ME (CPU queue 2) instead of the unresolved-route ACL (CPU queue 0) and the test fails.

Set FLAGS_classid_for_unresolved_routes = true in setCmdLineFlagOverrides() so the flag is present before agent init / SAI replay on both coldboot and warmboot. This also drops the Chenab vendor special-case that left the flag off in setup(). The flag is now always enabled for this test fixture.

Test Plan

[result] AgentCoppTest/0.UnresolvedRouteNextHopToLowPriQueue [coldboot]: PASSED (exit code 0)
[result] AgentCoppTest/0.UnresolvedRouteNextHopToLowPriQueue [warmboot]: PASSED (exit code 0)
[result] AgentCoppTest/1.UnresolvedRouteNextHopToLowPriQueue [coldboot]: PASSED (exit code 0)
[result] AgentCoppTest/1.UnresolvedRouteNextHopToLowPriQueue [warmboot]: PASSED (exit code 0)

@ram316583
ram316583 requested a review from a team as a code owner September 10, 2026 04:59
@meta-cla meta-cla Bot added the CLA Signed label Sep 10, 2026
@github-actions github-actions Bot added the cisco label Sep 10, 2026
@srikrishnagopu

Copy link
Copy Markdown
Contributor

Closing this based on the discussion

cc: @jasmeetbagga @vasantspatil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants