Conversation
Contributor
|
Closing this based on the discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
AgentCoppTest::UnresolvedRouteNextHopToLowPriQueuewas settingFLAGS_classid_for_unresolved_routesinside the per-testsetup()lambda.On warmboot,
setup()is skipped. SAI route replay then programs unresolved CPU routes with Metadata 0, so traffic hits IP2ME (CPU queue 2) instead of the unresolved-route ACL (CPU queue 0) and the test fails.Set
FLAGS_classid_for_unresolved_routes = trueinsetCmdLineFlagOverrides()so the flag is present before agent init / SAI replay on both coldboot and warmboot. This also drops the Chenab vendor special-case that left the flag off insetup(). The flag is now always enabled for this test fixture.Test Plan
[result] AgentCoppTest/0.UnresolvedRouteNextHopToLowPriQueue [coldboot]: PASSED (exit code 0)
[result] AgentCoppTest/0.UnresolvedRouteNextHopToLowPriQueue [warmboot]: PASSED (exit code 0)
[result] AgentCoppTest/1.UnresolvedRouteNextHopToLowPriQueue [coldboot]: PASSED (exit code 0)
[result] AgentCoppTest/1.UnresolvedRouteNextHopToLowPriQueue [warmboot]: PASSED (exit code 0)