Skip to content

build(single_file_libs): don't close sys.stdout in combine.py#4683

Open
vidigoat wants to merge 1 commit into
facebook:devfrom
vidigoat:fix/combine-no-close-stdout
Open

build(single_file_libs): don't close sys.stdout in combine.py#4683
vidigoat wants to merge 1 commit into
facebook:devfrom
vidigoat:fix/combine-no-close-stdout

Conversation

@vidigoat
Copy link
Copy Markdown

combine.py's output handle destn defaults to sys.stdout and is only reassigned to a real file when -o/--output is supplied. The finally block then calls destn.close() unconditionally — so running without -o (a documented mode; the -o help says output goes to stdout otherwise) closes sys.stdout.

Fix: only close the handle when it isn't sys.stdout.

Verified locally: with no -o, the stdout stream is no longer left closed after the run; with -o, the output file is still written/closed as before.

combine.py's output handle defaults to sys.stdout and is only reassigned to
a real file when -o/--output is given. The finally block closed it
unconditionally, so running without -o (a documented mode) closed sys.stdout.
Only close the handle when it isn't sys.stdout.

Signed-off-by: Vidit Patankar <vidit.patankar16@gmail.com>
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 31, 2026

Hi @vidigoat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla Bot added the CLA Signed label Jun 1, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Jun 1, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant