build(single_file_libs): don't close sys.stdout in combine.py#4683
build(single_file_libs): don't close sys.stdout in combine.py#4683vidigoat wants to merge 1 commit into
Conversation
combine.py's output handle defaults to sys.stdout and is only reassigned to a real file when -o/--output is given. The finally block closed it unconditionally, so running without -o (a documented mode) closed sys.stdout. Only close the handle when it isn't sys.stdout. Signed-off-by: Vidit Patankar <vidit.patankar16@gmail.com>
|
Hi @vidigoat! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
combine.py's output handledestndefaults tosys.stdoutand is only reassigned to a real file when-o/--outputis supplied. Thefinallyblock then callsdestn.close()unconditionally — so running without-o(a documented mode; the-ohelp says output goes to stdout otherwise) closessys.stdout.Fix: only close the handle when it isn't
sys.stdout.Verified locally: with no
-o, the stdout stream is no longer left closed after the run; with-o, the output file is still written/closed as before.