Fix hang on cyclic symlinks with -r -f#4691
Open
eyupcanakman wants to merge 1 commit into
Open
Conversation
With -r -f, the recursive directory walk follows symbolic links, so a symlink pointing back into an ancestor directory makes UTIL_prepareFileList loop forever and the CLI hangs. Track the (device, inode) of each directory on the current path and skip an entry whose target is already an ancestor. Fixes facebook#4081.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-r -f, zstd follows symbolic links while walking directories, so a symlink that points back into a directory it already sits in makes the walk loop forever and the CLI hangs.UTIL_prepareFileListnow records the (device, inode) of each directory on the current path and skips an entry whose target is already an ancestor, printing a warning. The new cli-test covers a cyclic symlink and a non-cyclic one.Fixes #4081.