Refactor: extract shared EigendecompositionBasedShampooKroneckerFactorsUnwrapped base class#261
Open
runame wants to merge 1 commit into
Open
Conversation
…rsUnwrapped base class Consolidate duplicated eigendecomposition logic from EigendecomposedShampooKroneckerFactorsUnwrapped and EigenvalueCorrectedShampooKroneckerFactorsUnwrapped into a shared base class. The base class provides _perform_eigendecomposition and _amortized_computation, with subclass behavior controlled via hasattr checks on field presence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
|
@hjmshi has imported this pull request. If you are a Meta employee, you can view this in D104874447. |
wz337
approved these changes
May 13, 2026
Contributor
wz337
left a comment
wz337
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EigendecompositionBasedShampooKroneckerFactorsUnwrappedbase class that unifies shared eigendecomposition logic betweenEigendecomposedShampooKroneckerFactorsUnwrappedandEigenvalueCorrectedShampooKroneckerFactorsUnwrapped.factor_matrices_eigenvectorsfield,_amortized_computationmethod, and__post_init__assertion. Eigenvalue inclusion is controlled by field presence (hasattr(self, "factor_matrices_eigenvalues")).Stack
This PR is part of a stack adding per-factor eigenvalue correction to Distributed Shampoo:
Test plan
distributed_shampoo/tests/,distributed_shampoo/preconditioner/tests/)make type-check)Generated with Claude Code