ci: one check for branch protection to require - #72
Merged
Merged
Conversation
Requiring the seven job names deadlocked the first documentation-only pull request, and not for the reason #69 anticipated. Skipping works: lint, language and fuzz all reported "skipping" on #71, which is a conclusion and satisfies a required check. But a skipped MATRIX job reports its name unexpanded -- literally "test (${{ matrix.os }})" rather than the three real ones -- so "test (ubuntu-latest)" and its two siblings never arrived at all, and the pull request sat BLOCKED on checks that cannot exist. Exactly the deadlock #69 set out to prevent, one level down. Requiring individual job names has a second problem worth fixing while here: every required name is coupled to a job name, so renaming a job silently stops protection enforcing it, with nothing anywhere to notice. So: a `ci` job that always runs, gates on the other five, and fails if any of them failed or was cancelled. Skipped is fine, since that is the filtering working as intended. It always reports because it always runs, whatever the jobs beneath it did. Branch protection should require this one check and nothing else. Adding a job later then needs no change to the ruleset, and renaming one cannot quietly disable it. The comparison pads both sides -- `case " $RESULTS " in *" failure "*` -- so a status that merely contains another as a substring cannot match by accident. Checked against all-success, all-skipped, a failure, a cancellation, and a failure among skips. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requiring the seven job names deadlocked the first documentation-only PR (#71), and not for the reason #69 anticipated.
Skipping works:
lint,languageandfuzzall reported skipping, which is a conclusion and satisfies a required check. But a skipped matrix job reports its name unexpanded — literallytest (${{ matrix.os }})rather than the three real ones — sotest (ubuntu-latest)and its siblings never arrived, and the PR satBLOCKEDon checks that cannot exist. The same deadlock #69 set out to prevent, one level down.Requiring individual job names has a second problem worth fixing while here: every required name is coupled to a job name, so renaming a job silently stops protection enforcing it, with nothing anywhere to notice.
What changed
cijob that always runs, gates on the other five, and fails if any failed or was cancelled. Skipped is fine — that is the filtering working. It always reports because it always runs.case " $RESULTS " in *" failure "*) so a status containing another as a substring cannot match by accident. Checked against all-success, all-skipped, a failure, a cancellation, and a failure among skips.After merging
Branch protection should require
ciand nothing else, replacing the seven. Adding a job later then needs no ruleset change, and renaming one cannot quietly disable enforcement.