ci: run the examples suite before a release too - #73
Merged
Merged
Conversation
The release workflow's verify job runs the characterization suite and the README blocks, and did not run the examples. check-examples.sh was added to CI in #58 and never mirrored here, so between then and now a tag could have published a commit whose examples were broken. v1.0.0 was not, but only because CI caught them on master first, which is luck rather than a guarantee. The same class of thing as the two builtin name lists: two places that have to say the same thing, with nothing making them. There is no check here either, so both now carry a comment pointing at the other. Collapsing the three into one script would remove the drift outright, and costs the thing the separate steps buy: a failure is attributed to the suite that failed rather than to a wrapper. Not worth trading for two files that change about once a year. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow's
verifyjob runs the characterization suite and the README blocks, and did not run the examples.check-examples.shwas added to CI in #58 and never mirrored here, so a tag could publish a commit whose examples were broken.v1.0.0was not, but only because CI caught them on master first, which is luck rather than a guarantee.What changed
verifynow runsscripts/check-examples.sh, so both workflows run the same three correctness suites.Collapsing the three into one script would remove the drift outright, at the cost of what the separate steps buy: a failure attributed to the suite that failed rather than to a wrapper. Not worth trading for two files that change about once a year.
Note this PR touches
.github/workflows/release.yml, so the release workflow builds all six archives without publishing, exercising the packaging alongside the change.