Skip to content

New Core library - #305

Draft
JensKrumsieck wants to merge 115 commits into
mainfrom
core_library
Draft

New Core library#305
JensKrumsieck wants to merge 115 commits into
mainfrom
core_library

Conversation

@JensKrumsieck

@JensKrumsieck JensKrumsieck commented Aug 4, 2026

Copy link
Copy Markdown
Member

GOAL: Refactor core library which now is called sciwin

Authoring

Execution

SciWIn-Client

  • Can export RO Crates from local backend

SciWIn-Studio

  • Binary renamed to sciwin_studio

Misc

  • Own Error-Types instead of anyhow in most places
  • Add global --debug flag to be extra verbose

Comment thread crates/sciwin/authoring/tool/parser/inputs.rs Fixed
Comment thread crates/sciwin/authoring/tool/parser/inputs.rs Fixed
Comment thread crates/sciwin/authoring/tool/parser/inputs.rs Fixed
Comment thread crates/gui/src/layout.rs Fixed
Comment thread crates/gui/src/lib.rs Fixed
Comment thread crates/gui/src/lib.rs Fixed
Comment thread crates/gui/src/lib.rs Fixed
Comment thread crates/gui/src/lib.rs Fixed
-- AI assisted refactor

fn save_workflow_name(instance_url: &str, name: &str) -> anyhow::Result<()> {
let file_path = status_file_path();
let mut workflows: HashMap<String, Vec<String>> = if file_path.exists() {
fn save_workflow_name(instance_url: &str, name: &str) -> anyhow::Result<()> {
let file_path = status_file_path();
let mut workflows: HashMap<String, Vec<String>> = if file_path.exists() {
let content = std::fs::read_to_string(&file_path)?;
if !entry.contains(&name.to_string()) {
entry.push(name.to_string());
}
std::fs::write(&file_path, serde_json::to_string_pretty(&workflows)?)?;

fn get_saved_workflows(instance_url: &str) -> Vec<String> {
let file_path = status_file_path();
if !file_path.exists() {
if !file_path.exists() {
return vec![];
}
let content = std::fs::read_to_string(&file_path).unwrap_or_default();
JensKrumsieck and others added 11 commits August 5, 2026 12:21
execute_integration_test.rs and graph.rs tests each use their own
tempdir/explicit outdir and never touch cwd or process env vars, so
they can run in parallel like the equivalent tool_integration_test.rs
tests already do. Also removes the now-dead `fstest::serial_test`
import in submodule.rs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
JensKrumsieck and others added 4 commits August 6, 2026 11:03
Co-authored-by: aleidel <aleidel1239897@gmail.de>
Co-authored-by: aleidel <aleidel1239897@gmail.de>
#272

Co-authored-by: aleidel <aleidel1239897@gmail.com>
this is where the magic happens, runner sees ontology and is able to run transitive checks
@JensKrumsieck JensKrumsieck mentioned this pull request Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
crates/gui/src/components 0%
crates/sciwin 64%
crates/sciwin/execution 24%
crates/cli 5%
crates/gui/src/components/graph 0%
crates/sciwin/authoring/tool 84%
crates/sciwin/repository 84%
crates/cli/commands 3%
crates/gui/src 0%
crates/gui/src/components/layout 0%
crates/sciwin/authoring 79%
crates/sciwin/project 73%
crates/gui/src/components/files 0%
crates/sciwin/authoring/tool/parser 85%
crates/sciwin/provenance 81%
Summary 44% (1478 / 3362)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Big Refactor Use CWL Reana Client infer file types/formats Create Workflow Run RO-Crates

2 participants