Skip to content

feat: Add engineering-standards#30

Merged
RasmusRendal merged 1 commit into
mainfrom
RasmusRendal/engineering_standards
Jun 17, 2026
Merged

feat: Add engineering-standards#30
RasmusRendal merged 1 commit into
mainfrom
RasmusRendal/engineering_standards

Conversation

@RasmusRendal

Copy link
Copy Markdown
Contributor

This project is severely missing a Nix dev shell, and engineering-standards
just became a very easy way to do it.

@RasmusRendal RasmusRendal force-pushed the RasmusRendal/engineering_standards branch from ae1f4cb to a076b41 Compare June 16, 2026 21:29
@RasmusRendal RasmusRendal marked this pull request as ready for review June 16, 2026 21:30
@RasmusRendal RasmusRendal requested a review from a team as a code owner June 16, 2026 21:30
emgrav
emgrav previously approved these changes Jun 17, 2026

@emgrav emgrav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, actually, quick question: The omnibus CI workflow is not running due to an input error, and it seems to mistakenly not be marked as a required job. I think we can not merge this until the CI actually passes, and I would anticipate problems with at least the REUSE compliance job from this PR.

@emgrav emgrav dismissed their stale review June 17, 2026 05:59

stale

@RasmusRendal RasmusRendal force-pushed the RasmusRendal/engineering_standards branch from 4f4f6db to aa0eda4 Compare June 17, 2026 14:44
This project is severely missing a Nix dev shell, and engineering-standards
just became a very easy way to do it.
@RasmusRendal RasmusRendal force-pushed the RasmusRendal/engineering_standards branch from aa0eda4 to eac2573 Compare June 17, 2026 14:47
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.18%. Comparing base (ec0ec43) to head (eac2573).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   74.18%   74.18%           
=======================================
  Files           5        5           
  Lines         275      275           
=======================================
  Hits          204      204           
  Misses         71       71           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec0ec43...eac2573. Read the comment docs.

@RasmusRendal RasmusRendal merged commit eac2573 into main Jun 17, 2026
8 checks passed
@RasmusRendal RasmusRendal deleted the RasmusRendal/engineering_standards branch June 17, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants