Skip to content

refactor: Use typed interfaces for generating EnvFilters from config#33

Open
RasmusRendal wants to merge 1 commit into
mainfrom
RasmusRendal/refactor_envfilter
Open

refactor: Use typed interfaces for generating EnvFilters from config#33
RasmusRendal wants to merge 1 commit into
mainfrom
RasmusRendal/refactor_envfilter

Conversation

@RasmusRendal

Copy link
Copy Markdown
Contributor

I think this is just nicer than returning a string that the consumer is
expected to parse.

I wish we could do this without any string parsing at all, but this
functionality is still missing.

This is arguably not a super important PR, but it's just something weird I spotted and wanted to fix.

I think this is just nicer than returning a string that the consumer is
expected to parse.

I wish we could do this without any string parsing at all, but this
functionality is still missing.
@RasmusRendal RasmusRendal requested a review from a team as a code owner June 17, 2026 16:20
@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.91%. Comparing base (eac2573) to head (c1d109a).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/config.rs 95.23% 1 Missing ⚠️
src/lib.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   74.18%   74.91%   +0.72%     
==========================================
  Files           5        5              
  Lines         275      283       +8     
==========================================
+ Hits          204      212       +8     
  Misses         71       71              
Files with missing lines Coverage Δ
src/config.rs 70.76% <95.23%> (+4.10%) ⬆️
src/lib.rs 88.29% <75.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac2573...c1d109a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant