refactor: Use typed interfaces for generating EnvFilters from config#33
Open
RasmusRendal wants to merge 1 commit into
Open
refactor: Use typed interfaces for generating EnvFilters from config#33RasmusRendal wants to merge 1 commit into
RasmusRendal wants to merge 1 commit into
Conversation
I think this is just nicer than returning a string that the consumer is expected to parse. I wish we could do this without any string parsing at all, but this functionality is still missing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 74.18% 74.91% +0.72%
==========================================
Files 5 5
Lines 275 283 +8
==========================================
+ Hits 204 212 +8
Misses 71 71
Continue to review full report in Codecov by Harness.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is just nicer than returning a string that the consumer is
expected to parse.
I wish we could do this without any string parsing at all, but this
functionality is still missing.
This is arguably not a super important PR, but it's just something weird I spotted and wanted to fix.